Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meroxa functions #239

Merged
merged 6 commits into from
Jan 26, 2022
Merged

Add meroxa functions #239

merged 6 commits into from
Jan 26, 2022

Conversation

owenthereal
Copy link
Contributor

@owenthereal owenthereal commented Jan 26, 2022

Description of change

Add meroxa functions. This depends on https://github.com/meroxa/meroxa-go/pull/90.

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging

Demo

$ m function create o-func --input-stream resource-4497-028165-users --image meroxa/funtime-example-jq --pipeline default --env JQ_QUERY=.
Function "o-func" successfully created!

$ m function list
                 UUID                    NAME            INPUT STREAM                    OUTPUT STREAM               STATE    PIPELINE
====================================== ========= ============================ ==================================== ========= ==========
 85e18535-1505-4fe4-97cb-da209687b597   o-func    resource-4497-028165-users   resource-4497-028165-users-o-func    running   default

$ m function describe o-func
          UUID:   85e18535-1505-4fe4-97cb-da209687b597
          Name:   o-func
  Input Stream:   resource-4497-028165-users
 Output Stream:   resource-4497-028165-users-o-func
         Image:   meroxa/funtime-example-jq
       Command:
     Arguments:
      Env Vars:   JQ_QUERY=.
      Pipeline:   default
         State:   Running

$ m function delete o-func
To proceed, type "o-func" or re-run this command with --force
▸ o-func
Function "o-func" is being removed...
Function "o-func" successfully removed

@owenthereal owenthereal self-assigned this Jan 26, 2022
Copy link
Member

@ahmeroxa ahmeroxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@owenthereal
Copy link
Contributor Author

The ftest test failed for --- FAIL: TestSQLServerToSQLServer/cleaning_up_create_test_db_testdb_vklu8e (25.80s) which is not relevant to this PR. I'm going to merge this to unblock other items.

@owenthereal owenthereal merged commit bac2204 into master Jan 26, 2022
@owenthereal owenthereal deleted the functions branch January 26, 2022 17:39
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

}

func (*Functions) Aliases() []string {
return []string{"function"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'd be nice to maybe also have fn as an alias? Just a thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants