Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add env create #201

Merged
merged 13 commits into from
Oct 22, 2021
Merged

feat: add env create #201

merged 13 commits into from
Oct 22, 2021

Conversation

raulb
Copy link
Member

@raulb raulb commented Oct 14, 2021

Description of change

Fixes #179

Relies on https://github.com/meroxa/meroxa-go/pull/60

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging

Additional references

  • Will refactor prompt in a separate pull-request.

@raulb raulb self-assigned this Oct 14, 2021
@raulb raulb force-pushed the raul/env-create branch 2 times, most recently from 02bfbc7 to 3d4bef9 Compare October 15, 2021 18:46
Copy link
Contributor

@dianadoherty dianadoherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I have some slight recommendations for the wording to make it more concise. Feel free to accept it or not 😄

cmd/meroxa/root/environments/create.go Outdated Show resolved Hide resolved
cmd/meroxa/root/environments/create.go Outdated Show resolved Hide resolved
cmd/meroxa/root/environments/create.go Outdated Show resolved Hide resolved
cmd/meroxa/root/environments/create.go Outdated Show resolved Hide resolved
raulb and others added 3 commits October 22, 2021 12:12
Co-authored-by: Diana Doherty <[email protected]>
Co-authored-by: Lovro Mažgon <[email protected]>
@raulb raulb marked this pull request as ready for review October 22, 2021 15:01
@raulb raulb merged commit 28fe46c into master Oct 22, 2021
@raulb raulb deleted the raul/env-create branch October 22, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stage 1: CLI] meroxa env create
2 participants