-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add env create #201
Merged
Merged
feat: add env create #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulb
force-pushed
the
raul/env-create
branch
2 times, most recently
from
October 15, 2021 18:46
02bfbc7
to
3d4bef9
Compare
raulb
force-pushed
the
raul/env-create
branch
from
October 20, 2021 10:36
429272b
to
e9f969d
Compare
raulb
force-pushed
the
raul/env-create
branch
from
October 21, 2021 17:52
acebb76
to
5c46e2b
Compare
dianadoherty
approved these changes
Oct 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I have some slight recommendations for the wording to make it more concise. Feel free to accept it or not 😄
Co-authored-by: Diana Doherty <[email protected]>
Co-authored-by: Diana Doherty <[email protected]>
Co-authored-by: Lovro Mažgon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes #179
Relies on https://github.com/meroxa/meroxa-go/pull/60
Type of change
How was this tested?
Additional references