-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remove): Require confirmation prompt or -f
before removing a resource
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulb
requested review from
ahmeroxa,
anaptfox,
dianadoherty,
mwoods79 and
lovromazgon
March 30, 2021 09:59
raulb
force-pushed
the
raul/force-remove
branch
from
March 30, 2021 10:24
f7e5c5d
to
b1e0a0d
Compare
mwoods79
approved these changes
Mar 30, 2021
dianadoherty
approved these changes
Mar 30, 2021
raulb
force-pushed
the
raul/force-remove
branch
from
March 30, 2021 16:45
bfe7308
to
491df78
Compare
Once we ship https://github.com/meroxa/acceptance/pull/25, this one should be good to go. |
raulb
force-pushed
the
raul/force-remove
branch
from
March 30, 2021 17:13
491df78
to
128721f
Compare
raulb
force-pushed
the
raul/force-remove
branch
from
March 30, 2021 17:14
128721f
to
0b2b667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes https://meroxa.atlassian.net/browse/PLATFORM-31
Before removing a resource, we want to prompt for confirmation unless the
-f
or--force
was specified. This pull-request adds that feature. See demo below.This pull request also includes some new tests more inline with the recently added in #98.
Type of change
How was this tested?
Demo
With
--force
\-f
With an incorrect confirmation value
With a correct confirmation value