lint

meroxa · Aug 30, 2022 · 17351ac · 17351ac
1 parent e0c03f7
commit 17351ac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/cmd/meroxa/root/apps/deploy.go b/cmd/meroxa/root/apps/deploy.go
@@ -421,7 +421,7 @@ func (d *Deploy) buildApp(ctx context.Context) error {
 		}
 		d.logger.StopSpinnerWithStatus("Application built", log.Successful)
 	}
-	return nil
+	return err
 }
 
 // getAppImage will check what type of build needs to perform and ultimately will return the image name to use
@@ -490,8 +490,6 @@ func (d *Deploy) validateLanguage() error {
 func (d *Deploy) validateAppJSON(ctx context.Context) error {
 	var err error
 
-	// d.logger.Info(ctx, "Validating your app.json...") @TODO suspect
-
 	// validateLocalDeploymentConfig will look for DockerHub credentials to determine whether it's a local deployment or not.
 	if err = d.validateLocalDeploymentConfig(); err != nil {
 		return err
@@ -589,8 +587,6 @@ func (d *Deploy) checkResourceAvailability(ctx context.Context) error {
 }
 
 func (d *Deploy) prepareDeployment(ctx context.Context) error {
-	// d.logger.Infof(ctx, "Deploying application %q...", d.appName) @TODO suspect
-
 	// After this point, CLI will package it up and will build it
 	err := d.buildApp(ctx)
 	if err != nil {
@@ -636,7 +632,6 @@ func (d *Deploy) validateSpecVersionDeployment() error {
 
 // validateConfig will validate wether there are uncommitted changes or it's deploying from an accepted branch.
 func (d *Deploy) validateGitConfig(ctx context.Context) error {
-	//d.logger.Info(ctx, "Checking for uncommitted changes...")
 	err := turbineCLI.GitChecks(ctx, d.logger, d.path)
 	if err != nil {
 		return err

diff --git a/cmd/meroxa/turbine/golang/build.go b/cmd/meroxa/turbine/golang/build.go
@@ -26,10 +26,10 @@ func BuildBinary(ctx context.Context, l log.Logger, appPath, appName string, pla
 		l.StopSpinnerWithStatus(string(stdout), log.Failed)
 		return fmt.Errorf("build failed")
 	}
-	return buildForCrossCompile(ctx, l, appPath, appName)
+	return buildForCrossCompile(l, appPath, appName)
 }
 
-func buildForCrossCompile(ctx context.Context, l log.Logger, appPath, appName string) error {
+func buildForCrossCompile(l log.Logger, appPath, appName string) error {
 	cmd := exec.Command("go", "build", "--tags", "platform", "-o", appName+".cross", "./...") //nolint:gosec
 	cmd.Env = os.Environ()
 	cmd.Env = append(cmd.Env, "CGO_ENABLED=0", "GOOS=linux", "GOARCH=amd64")