Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates node-sass to 4.12 and regenerates lockfiles #978

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

aledileo
Copy link
Contributor

@aledileo aledileo commented Oct 6, 2019

Solves: #961
node-sass 4.12 works fine with node 12, the issue originated from having both yarn and npm lockfiles and them using different versions of the library. May I suggest sticking to only one package manager? It would decrease the amount of bugs like this one

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1058

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.56%

Totals Coverage Status
Change from base Build 1056: 0.0%
Covered Lines: 2643
Relevant Lines: 4887

💛 - Coveralls

@klemmchr
Copy link
Member

klemmchr commented Oct 8, 2019

I would also favor for using just one package manager.

@Bjego
Copy link

Bjego commented Oct 9, 2019

Instead of updating node-sass - I would port to dart sass. Node-Sass is a legacy implementation and has been replaced by dart-sass.

Dart Sass is the primary implementation of Sass, which means it gets new features before any other implementation. It's fast, easy to install, and it compiles to pure JavaScript which makes it easy to integrate into modern web development workflows. Find out more or help out with its development on GitHub.

https://sass-lang.com/dart-sass

And node-sass is based on the C-Based library "Lib-Sass"

Node-sass is a library that provides binding for Node.js to LibSass, the C version of the popular stylesheet preprocessor, Sass.
https://github.com/sass/node-sass

I've created an issue for that #986

@knsv
Copy link
Collaborator

knsv commented Oct 15, 2019

There can be only one. Let's use yarn and remove package-lock.json

@knsv knsv merged commit 97a5f40 into mermaid-js:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants