-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class diagram: annotations support #973
Class diagram: annotations support #973
Conversation
Pull Request Test Coverage Report for Build 1052
💛 - Coveralls |
The image in the readme needs to be regenerated. Is there a tool for this or is it done by hand? |
@Chris579 great job! I am asking Ashish to do amore detailed review this before merging. |
We will merge this to develop and the feature will be included in the version 9. In version 9 class diagrams will be moved from experimental to officially supported with proper docs etc. |
Is there already a vague ETA for Version 9? |
* @public | ||
*/ | ||
export const addAnnotation = function(className, annotation) { | ||
classes[className].annotations.push(annotation); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unhappy about that. This will throw an exception if an annotation is defined before the class itself. It seems like there is no error handling about this at all, even for the members. How to treat that?
Merging Pull request to master. |
Resolves #963
I added support for class annotations and did some minor changes needed for this feature.
I centered the class title because it would look quite odd it the annotation and the class title would be left aligned. Also I made the class title bold to make it distinguishable from the annotations. I decided for this syntax: