-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use https in github urls #940
Conversation
Thank you for the interest in the project and the pull request! Regarding the svg xmlns links, I'm not an expert in the matter but I believe those are not real URLs (even though they actually are) and are just namespaces as defined per specs. Examples of the specs that show a non-https namespace can be seen by just following those URLs: Note that the namespaces defined in the specs are not https.
Again, thank you very much! |
Yeah, I dunno either if it brings a benefit. The only one I can see is that if you click that link or follow it you are making an http request in the clear and even though the response will be over https its still a request and can be theoretically man-in-the-middled / hijacked etc. Obviously the W3C itself has an https redirect in place, because its probably easier to do that on the server-side than it is through the working groups. |
I will be happy to merge this if https is what it should be now days. Would appreciate if someone could investigate. Don't want to mess up peoples diagrams by misstake. |
Hey! Thanks for filling the issue with the w3c! I'd be happy to merge the change to the github url on its own! |
That sounds like a plan! Please update the pr:
|
I reverted to HTTP - just leaving the links to github |
This is a trivial fix, but the xmlns links in the SVGs were using
"http://www.w3.org/1999/xhtml"
I believe that
xmlns="https://www.w3.org/1999/xhtml"
is better so I cleaned it up wherever I could find it. I tested with a yarn link and it works as expected.Also fixed a couple http links to the gh-pages. ;)