Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render nodes as real links #765

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Render nodes as real links #765

merged 2 commits into from
Dec 17, 2018

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Nov 28, 2018

Fixes #689.

I think we should replicate the HTML label behavior manually instead of relying on dagre-d3-renderer (i.e. if labelTypeStr === 'html', we create a foreignObject ourselves and pass it to the library).

That way we can wrap the whole thing in a SVG <a>...</a> object instead of only having the narrow link text clickable.

@coveralls
Copy link

coveralls commented Nov 28, 2018

Pull Request Test Coverage Report for Build 701

  • 9 of 28 (32.14%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0005%) to 54.285%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/diagrams/flowchart/flowRenderer.js 0 8 0.0%
src/diagrams/flowchart/flowDb.js 5 16 31.25%
Totals Coverage Status
Change from base Build 671: -0.0005%
Covered Lines: 2049
Relevant Lines: 3752

💛 - Coveralls

@tylerlong tylerlong merged commit a57b908 into mermaid-js:master Dec 17, 2018
@flying-sheep flying-sheep deleted the links branch December 17, 2018 09:32
@flying-sheep flying-sheep mentioned this pull request Feb 6, 2019
3 tasks
mgenereu pushed a commit to mgenereu/mermaid that referenced this pull request Jun 25, 2022
…yarn/develop/sveltejs/kit-1.0.0-next.324

chore(deps-dev): bump @sveltejs/kit from 1.0.0-next.318 to 1.0.0-next.324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants