Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Venn diagram #5932

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

feat: Add Venn diagram #5932

wants to merge 2 commits into from

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Oct 4, 2024

๐Ÿ“‘ Summary

Resolves #2583

๐Ÿ“ Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

๐Ÿ“‹ Tasks

Make sure you

  • ๐Ÿ“– have read the contribution guidelines
  • ๐Ÿ’ป have added necessary unit/e2e tests.
  • ๐Ÿ““ have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • ๐Ÿฆ‹ If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Screenshot

image

Copy link

changeset-bot bot commented Oct 4, 2024

โš ๏ธ No Changeset found

Latest commit: 53abdf9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 4, 2024

โœ… Deploy Preview for mermaid-js ready!

Name Link
๐Ÿ”จ Latest commit 53abdf9
๐Ÿ” Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6700ebea436c900008c70127
๐Ÿ˜Ž Deploy Preview https://deploy-preview-5932--mermaid-js.netlify.app
๐Ÿ“ฑ Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 5, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@5932
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@5932
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@5932
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@5932

commit: 53abdf9

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 0.84507% with 352 lines in your changes missing coverage. Please review.

Project coverage is 4.64%. Comparing base (ddf18dd) to head (53abdf9).
Report is 81 commits behind head on develop.

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/venn/styles.ts 0.00% 162 Missing โš ๏ธ
packages/mermaid/src/diagrams/venn/vennRenderer.ts 0.00% 90 Missing โš ๏ธ
packages/mermaid/src/diagrams/venn/vennDB.ts 0.00% 58 Missing โš ๏ธ
packages/mermaid/src/diagrams/venn/vennDetector.ts 0.00% 24 Missing โš ๏ธ
packages/mermaid/src/diagrams/venn/vennDiagram.ts 0.00% 13 Missing โš ๏ธ
...s/mermaid/src/diagram-api/diagram-orchestration.ts 0.00% 3 Missing โš ๏ธ
.build/jsonSchema.ts 0.00% 1 Missing โš ๏ธ
packages/mermaid/src/docs/.vitepress/config.ts 0.00% 1 Missing โš ๏ธ
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5932      +/-   ##
==========================================
- Coverage     4.67%   4.64%   -0.03%     
==========================================
  Files          372     377       +5     
  Lines        51669   52023     +354     
  Branches       611     616       +5     
==========================================
+ Hits          2414    2417       +3     
- Misses       49255   49606     +351     
Flag Coverage ฮ”
unit 4.64% <0.84%> (-0.03%) โฌ‡๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage ฮ”
packages/mermaid/src/defaultConfig.ts 45.38% <100.00%> (+0.61%) โฌ†๏ธ
.build/jsonSchema.ts 0.00% <0.00%> (รธ)
packages/mermaid/src/docs/.vitepress/config.ts 0.00% <0.00%> (รธ)
...s/mermaid/src/diagram-api/diagram-orchestration.ts 0.00% <0.00%> (รธ)
packages/mermaid/src/diagrams/venn/vennDiagram.ts 0.00% <0.00%> (รธ)
packages/mermaid/src/diagrams/venn/vennDetector.ts 0.00% <0.00%> (รธ)
packages/mermaid/src/diagrams/venn/vennDB.ts 0.00% <0.00%> (รธ)
packages/mermaid/src/diagrams/venn/vennRenderer.ts 0.00% <0.00%> (รธ)
packages/mermaid/src/diagrams/venn/styles.ts 0.00% <0.00%> (รธ)

Copy link

argos-ci bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Argos notifications โ†—๏ธŽ

Build Status Details Updated (UTC)
default (Inspect) โœ… No changes detected - Oct 5, 2024, 7:55 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Venn Diagram Syntax
1 participant