Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(sankey): default to useMaxWidth true #5724

Merged

Conversation

aloisklink
Copy link
Member

📑 Summary

Note

I've stacked this PR on top of the following to avoid merge conflicts. Please merge them first:

Change the default value for sankey.useMaxWidth to true, as all mermaid diagrams default to useMaxWidth as true, with the exception of git graphs (which will be fixed in #5723).

The documentation currently says it defaults to true, so changing this matches the documentation. See:

useMaxWidth:
description: |
When this flag is set to `true`, the height and width is set to 100%
and is then scaled with the available space.
If set to `false`, the absolute space required is used.
type: boolean
default: true

BREAKING CHANGE: Changes the default value of useMaxWidth for sankey diagrams to true. This is technically a breaking change, but considering that most of the other diagrams default to true, I think this is unlikely to impact anybody.

However, if anybody does want the old behavior, they can always explicitly set { sankey: { useMaxWidth: false } }.

📏 Design Decisions

N/A

📋 Tasks

Make sure you

All other diagrams (with the exception of Sankey) default to `true`.

BREAKING CHANGE: Change the default value of `useMaxWidth` for gitgraphs
                 to `true`.
All other diagrams default to `useMaxWidth` `true`.

BREAKING CHANGE: Change the default value of `useMaxWidth` for sankey
                 diagrams to `true`.
@aloisklink aloisklink added Type: Other Not an enhancement or a bug Graph: Sankey Breaking Change Breaking change labels Aug 20, 2024
@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Aug 20, 2024
Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit d82958d
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66c46b1b940077000895fa78
😎 Deploy Preview https://deploy-preview-5724--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.19%. Comparing base (04c29e2) to head (d82958d).
Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5724      +/-   ##
==========================================
- Coverage     5.22%   5.19%   -0.03%     
==========================================
  Files          323     323              
  Lines        46212   46199      -13     
  Branches       537     537              
==========================================
- Hits          2415    2402      -13     
  Misses       43797   43797              
Flag Coverage Δ
unit 5.19% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/defaultConfig.ts 44.56% <ø> (-2.58%) ⬇️

Copy link

argos-ci bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 85 changed Aug 20, 2024, 10:20 AM

@knsv knsv added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit Aug 20, 2024
@knsv knsv added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit Aug 20, 2024
@knsv knsv merged commit c5dfa42 into mermaid-js:develop Aug 20, 2024
19 of 20 checks passed
@aloisklink aloisklink deleted the fix/default-sankey-useMaxWidth-to-true branch August 20, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Breaking change Graph: Sankey Type: Bug / Error Something isn't working or is incorrect Type: Other Not an enhancement or a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants