Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed entrypoint path #5566

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Conversation

nirname
Copy link
Contributor

@nirname nirname commented Jun 8, 2024

📑 Summary

Docker compose was not properly loading entrypoint.sh, which resulted in wrong PATH and pnpm command not being found

Resolves #5565

📏 Design Decisions

  • Added ./ to specify local path respective to context
  • Added /tmp folder for making patches, but it is not needed anymore

📋 Tasks

Make sure you

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Jun 8, 2024
Copy link

netlify bot commented Jun 8, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 8f00555
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66730c8a79e10400089aeb04
😎 Deploy Preview https://deploy-preview-5566--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.73%. Comparing base (d84b440) to head (8f00555).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5566   +/-   ##
=======================================
  Coverage     5.73%   5.73%           
=======================================
  Files          278     277    -1     
  Lines        41999   41988   -11     
  Branches       490     515   +25     
=======================================
  Hits          2409    2409           
+ Misses       39590   39579   -11     
Flag Coverage Δ
unit 5.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@sidharthv96 sidharthv96 added this pull request to the merge queue Jun 19, 2024
Merged via the queue into develop with commit 63f9e95 Jun 19, 2024
29 checks passed
@sidharthv96 sidharthv96 deleted the bug/5565-fix-docker-local-development branch June 19, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker installation not working sh: pnpm: command not found
2 participants