Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/5525 sequence diagram fix note z position #5564

Conversation

Ronid1
Copy link
Contributor

@Ronid1 Ronid1 commented Jun 7, 2024

📑 Summary

Fixed actor figure line to be positioned behind notes.

Resolves #5525

📏 Design Decisions

📋 Tasks

Make sure you

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Jun 7, 2024
Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit fb1942c
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66742b2b2952aa00086c20e6
😎 Deploy Preview https://deploy-preview-5564--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 5.73%. Comparing base (a331125) to head (fb1942c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5564   +/-   ##
=======================================
  Coverage     5.73%   5.73%           
=======================================
  Files          278     277    -1     
  Lines        41999   41988   -11     
  Branches       490     515   +25     
=======================================
  Hits          2409    2409           
+ Misses       39590   39579   -11     
Flag Coverage Δ
unit 5.73% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/diagrams/sequence/svgDraw.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

argos-ci bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 added Jun 20, 2024, 1:27 PM

@sidharthv96 sidharthv96 added this pull request to the merge queue Jun 20, 2024
Merged via the queue into mermaid-js:develop with commit 4b21e1e Jun 20, 2024
19 checks passed
@Ronid1 Ronid1 deleted the bug/5525_sequence_diagram_fix_note_z_position branch June 20, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actor type in sequence diagram has wrong ordering
2 participants