ci(e2e): avoid commenting on PRs in CI, fixing PRs from forks #5365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Actions can't comment on PRs, if the PR is made from a forked repo, as [the github token won't have write permissions][1]. However, we can instead use GitHub Actions' [Adding a Job Summary][2] feature, which prints some custom output for each job. [1]: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#changing-the-permissions-in-a-forked-repository [2]: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary Fix: e0448a7
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5365 +/- ##
========================================
Coverage 44.67% 44.67%
========================================
Files 25 25
Lines 5339 5339
Branches 27 27
========================================
Hits 2385 2385
Misses 2953 2953
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
GitHub Actions can't comment on PRs, if the PR is made from a forked repo, as the github token won't have write permissions. This causes the E2E CI to fail in most PRs, e.g. see #5338 (comment)
However, we can instead use GitHub Actions' Adding a Job Summary feature, which prints some custom output for each job. This also means that we can calculate the bundle size for push events, not just PRs. For example, see https://github.com/aloisklink/mermaid/actions/runs/8177226929:
The only issue is that
Fix: e0448a7
📏 Design Decisions
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch