Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribute #5268

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Conversation

FutzMonitor
Copy link
Contributor

@FutzMonitor FutzMonitor commented Feb 5, 2024

📑 Summary

I added a Discord invite link to the intro.html file so that new contributors can quickly join the Mermaid DIscord server and chat with other members of the community.

This doesn't resolve any issue in the issue tracker. I had previously closed this issue because I thought PR #5225 addressed this page on the Mermaid website.

📏 Design Decisions

I simply created an invite link that didn't expire and added it to the page.

📋 Tasks

Make sure you

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit ec7591b
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65c5deac3f7ab50007ac9c22
😎 Deploy Preview https://deploy-preview-5268--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sidharthv96 sidharthv96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase the branch to target master please?

Comment on lines 42 to 43
[Join our slack community if you want closer contact!](https://join.slack.com/t/mermaid-talk/shared_invite/enQtNzc4NDIyNzk4OTAyLWVhYjQxOTI2OTg4YmE1ZmJkY2Y4MTU3ODliYmIwOTY3NDJlYjA0YjIyZTdkMDMyZTUwOGI0NjEzYmEwODcwOTE)

[You can also join our Discord server!](https://discord.gg/vVDmXwhpaS)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the slack link.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the Discord invite link to:

https://discord.gg/AgrbSrBer3

Comment on lines 42 to 43
[Join our slack community if you want closer contact!](https://join.slack.com/t/mermaid-talk/shared_invite/enQtNzc4NDIyNzk4OTAyLWVhYjQxOTI2OTg4YmE1ZmJkY2Y4MTU3ODliYmIwOTY3NDJlYjA0YjIyZTdkMDMyZTUwOGI0NjEzYmEwODcwOTE)

[You can also join our Discord server!](https://discord.gg/vVDmXwhpaS)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the Discord invite link to:

https://discord.gg/AgrbSrBer3

docs/community/intro.md Show resolved Hide resolved
@FutzMonitor FutzMonitor changed the base branch from develop to master February 6, 2024 14:53
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80c20a7) 80.08% compared to head (56999f4) 43.22%.
Report is 127 commits behind head on develop.

❗ Current head 56999f4 differs from pull request most recent head ec7591b. Consider uploading reports for the commit ec7591b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5268       +/-   ##
============================================
- Coverage    80.08%   43.22%   -36.87%     
============================================
  Files          167       23      -144     
  Lines        13867     5037     -8830     
  Branches       741       23      -718     
============================================
- Hits         11106     2177     -8929     
- Misses        2594     2859      +265     
+ Partials       167        1      -166     
Flag Coverage Δ
e2e ?
unit 43.22% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/config.ts 52.22% <100.00%> (-16.73%) ⬇️

... and 162 files with indirect coverage changes

@sidharthv96 sidharthv96 changed the base branch from master to develop February 9, 2024 08:11
1. Added a link to the Discord server
1. Removed the Slack invite and left only the Discord invite
1. Removed the Slack link
2. Updated the Discord invite link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants