Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Convert flowDB to TS #5077

Merged
merged 11 commits into from
Jan 19, 2024
Merged

refactor: Convert flowDB to TS #5077

merged 11 commits into from
Jan 19, 2024

Conversation

sidharthv96
Copy link
Member

📑 Summary

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit e8f6554
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65aa33177f331e0008a6ff03
😎 Deploy Preview https://deploy-preview-5077--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58b6cf0) 44.50% compared to head (e8f6554) 44.50%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #5077   +/-   ##
=======================================
  Coverage   44.50%   44.50%           
=======================================
  Files          25       25           
  Lines        5206     5206           
  Branches       25       25           
=======================================
  Hits         2317     2317           
  Misses       2888     2888           
  Partials        1        1           
Flag Coverage Δ
unit 44.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@aloisklink aloisklink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for doing this refactoring.

packages/mermaid/src/diagrams/flowchart/flowDb.ts Outdated Show resolved Hide resolved
packages/mermaid/src/diagrams/flowchart/flowDb.ts Outdated Show resolved Hide resolved
sidharthv96 and others added 3 commits January 19, 2024 13:48
* next: (194 commits)
  Use pixelmatch for image comparison
  Run all tests
  Fix lint
  Update lockfile
  E2E test
  Use cache to store snapshots
  chore(deps): update all patch dependencies
  Change string concatenation to template literal
  Revert "Revert 5041 feature/4935 subgraph title margin config option"
  build(deps-dev): bump follow-redirects from 1.15.2 to 1.15.5
  Draft release on master
  docs: Add release version
  Revert "fix: render the participants in same order as they are created"
  Revert "Feature/4935 subgraph title margin config option"
  Fix typo
  Run dev docs without npx
  Remove npx completely from run script
  Update docs
  Fix linters
  Removed volta requirement, leave pnpm only
  ...
@sidharthv96 sidharthv96 merged commit 6261fce into next Jan 19, 2024
17 of 25 checks passed
@sidharthv96 sidharthv96 deleted the sidv/FlowDB_TS branch January 19, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants