Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to diagram priority when overriding. #5051

Closed
wants to merge 3 commits into from

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Nov 20, 2023

📑 Summary

Adds support for a priority field when registering diagrams.
Diagrams with higher priority can override ones with lower priority, if they have the same ID.

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

Allows external diagrams to override internal diagrams, if necessary.
This will help move ELK to a different package, without completely breaking rendering, by falling back to dagre, and supporting ELK if it's registered as an external diagram.
* sidv/splitELK:
  5043 Move ELK to standalone package
@sidharthv96 sidharthv96 mentioned this pull request Nov 20, 2023
2 tasks
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #5051 (4a62e7f) into sidv/splitELK (0fec0ef) will decrease coverage by 0.08%.
The diff coverage is 23.52%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           sidv/splitELK    #5051      +/-   ##
=================================================
- Coverage          44.36%   44.28%   -0.08%     
=================================================
  Files                 25       25              
  Lines               5218     5236      +18     
  Branches              25       25              
=================================================
+ Hits                2315     2319       +4     
- Misses              2902     2916      +14     
  Partials               1        1              
Flag Coverage Δ
unit 44.28% <23.52%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/diagram-api/diagramAPI.ts 57.30% <30.00%> (-1.53%) ⬇️
packages/mermaid/src/diagram-api/detectType.ts 59.79% <20.83%> (-6.48%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant