Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate @types/d3-scale dev dependency #4749

Merged

Conversation

Yokozuna59
Copy link
Member

📑 Summary

remove duplicate @types/d3-scale dev dependency and minor sort to dev deps.

📋 Tasks

Make sure you

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #4749 (9cb62f4) into next (13852b7) will decrease coverage by 0.74%.
Report is 109 commits behind head on next.
The diff coverage is 87.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #4749      +/-   ##
==========================================
- Coverage   46.09%   45.36%   -0.74%     
==========================================
  Files          53       52       -1     
  Lines        6736     6649      -87     
  Branches       32       32              
==========================================
- Hits         3105     3016      -89     
- Misses       3630     3632       +2     
  Partials        1        1              
Flag Coverage Δ
unit 45.36% <87.50%> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/mermaid/src/utils.ts 38.07% <71.42%> (+0.16%) ⬆️
packages/mermaid/src/defaultConfig.ts 44.23% <100.00%> (+0.41%) ⬆️
...s/mermaid/src/diagram-api/diagram-orchestration.ts 30.23% <100.00%> (ø)
packages/mermaid/src/diagrams/common/common.ts 64.15% <100.00%> (+0.16%) ⬆️
packages/mermaid/src/diagrams/pie/pieDetector.ts 77.27% <100.00%> (-1.90%) ⬇️
packages/mermaid/src/setupGraphViewbox.js 36.14% <100.00%> (-0.77%) ⬇️

... and 1 file with indirect coverage changes

@sidharthv96 sidharthv96 merged commit 8678cee into mermaid-js:next Aug 20, 2023
12 checks passed
@Yokozuna59 Yokozuna59 deleted the remove-duplicate-dev-dependency branch August 20, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants