-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zenuml support #3983
Add Zenuml support #3983
Conversation
It fails e2e test.
Build zenuml core
Merge develop from origin
This fixed failing tests.
It causes error on github actions.
Zs3/fix test and lint
For more information, please see https://github.com/ZenUml/core/blob/main/docs/xss.md.
Fixed an XSS vulnerability.
Converting to draft to prevent accidental merging. Adding this into mermaid repo will make it gigantic and will also be hard to maintain. @MrCoder I'll help with the move as you've poured a lot of time and effort into this. I hope you understand why we have to go with this approach. To avoid any further complications, let's discuss what we're planning to do here. Integrating ZenUML to MermaidObjective: Move ZenUML core code to a location where mermaid maintainers have access to maintain and make releases to the Current plan: Create a Way forward: graph TD
A[Create mermaid/zenuml-core] --> C{Will Zenuml/core be archived?}
C -->|Yes| D[Keep replica of zenuml-core in mermaid/zenuml-core]
C -->|No| E[What's the plan to keep both repos in sync?]
D --> Release[Release zenuml core package from this repo]
Release --> Ref[Create mermaid-zenuml diagram in mermaid repo]
E --> NoRef[mermaid-zenuml cannot add zenuml-core as dependency <br> as it will not be released from our repo]
NoRef --> Standalone[mermaid-zenuml package will be built and published from mermaid/zenuml-core repo]
|
I agree! The current Mermaid source-code is only 575 files (counted with I'm struggling to even review the code changes, because the moment I click review on GitHub, GitHub freezes up and my tabs/browser crashes! The mermaid team is struggling a bit to maintain the current mermaid source code, and adding more code to maintain will be even harder! |
@sidharthv96, @aloisklink, thank you for your help. Just to clarify, most of the 3000+ are svg icons (AWS Cloud Service, GCP, Azure, etc). Only a small proportion of these icons are used, but we don't want to maintain a handpicked list of files, as they are published as a whole by each provider. Not counting the svg icons, the total number of files (including test) is 249 with |
@MrCoder, I understand that the files are not directly from ZenUML, but, the files are there. Can we discuss which path we should take from the flowchart in my previous comment? |
|
📑 Summary
Adding support for ZenUML Sequence Diagram.
Resolves #3435
📏 Design Decisions
ZenUML support code (with the source code of ZenUML/core) is in the mermaid-zenuml folder. Documents and Test are added to corresponding folders.
📋 Tasks
Make sure you
develop
branch