fix: Assign proper namespaces to foreignObject children #2119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
This fixes a bug where if the mermaid diagram is rendered directly (without being taken out as
innerHTML
and going through the HTML parser again after it was first rendered), journey diagrams will not properly show task text, due to these foreignObjects being created in thesvg
namespace. This patch adds thexhtml
namespace for thediv
elements so that they are created in the proper namespace.Illustration of the problem:
📏 Design Decisions
Inspired by the usage of
xhtml:div
here:mermaid/src/dagre-wrapper/createLabel.js
Line 65 in e6e94ad
📋 Tasks
Make sure you
develop
branch