New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Update default log level value with correct datatype #2083

Merged

knsv merged 1 commit into mermaid-js:develop from hydrosquall:patch-1

Jun 25, 2021

Contributor

hydrosquall commented May 19, 2021 •

edited

Loading

📑 Summary

Updates public documentation on a default config's log level, noticed while updating the typescript types for this library (passing a default string value was rejected by the TS compiler)

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/ad547b312b579f60fad35c5bcdcaec44035dfd78/types/mermaid/mermaidAPI.d.ts#L4-L10

See

mermaid/src/defaultConfig.js

Line 83 in d3f8f03

logLevel: 5,

for the corresponding source code. The current string log level won't have the intended effect.

📋 Tasks

Make sure you

📖 have read the contribution guidelines
💻 have added unit/e2e tests (if appropriate)
🔖 targeted develop branch


          [docs] Update default log level value

5fb8d34

knsv approved these changes

View reviewed changes

knsv merged commit a78ccb4 into mermaid-js:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet