Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2050 direction in subgraphs #2082

Merged
merged 3 commits into from
May 18, 2021
Merged

2050 direction in subgraphs #2082

merged 3 commits into from
May 18, 2021

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented May 18, 2021

📑 Summary

Adds a feature that enables the flowchart author to use a direction statement to set the direction in subgraphs in the new flowchart graph type.

Resolves #1265, #1576, #1678, #1682, #1949, #2050

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@knsv knsv merged commit ff75122 into develop May 18, 2021
@@ -610,4 +610,27 @@ flowchart RL
{htmlLabels: true, flowchart: {htmlLabels: true}, securityLevel: 'loose'}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knsv It looks like the Resolves xxx statement in the issue description only closed the first issue in the list when this merged.

Thanks for great addition! ❤️

@knsv knsv deleted the 2050_direction_in_subgraphs branch July 5, 2021 08:41
@baardkrk
Copy link

baardkrk commented Nov 9, 2021

Great addition, however, TD doesn't work in subgraphs (TB works though!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to declares the direction of the subgraph layout?
3 participants