Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The vertical position was wrongly based on index in sorted array. #1911

Merged
merged 1 commit into from
Feb 27, 2021
Merged

The vertical position was wrongly based on index in sorted array. #1911

merged 1 commit into from
Feb 27, 2021

Conversation

Rutorai
Copy link
Contributor

@Rutorai Rutorai commented Feb 26, 2021

📑 Summary

The vertical transformation-origin was based on the index of the task in the sorted tasks array. It must be computed on d.order like y value.

Resolves #1651

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • [ X] 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • [ X] 🔖 targeted develop branch

@knsv knsv merged commit 0646b43 into mermaid-js:develop Feb 27, 2021
@Rutorai Rutorai deleted the bug/1651_milestone_incorrect_vertical_position branch February 27, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants