Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lodash with specific implementations #1392

Merged
merged 2 commits into from
May 13, 2020
Merged

Replace lodash with specific implementations #1392

merged 2 commits into from
May 13, 2020

Conversation

hikerpig
Copy link
Contributor

@hikerpig hikerpig commented May 7, 2020

📑 Summary

A good start to reduce bundle size.

Resolves #1389

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@knsv knsv merged commit a636aa5 into mermaid-js:develop May 13, 2020
knsv
knsv approved these changes May 13, 2020
View reviewed changes
Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It will be interesting to compare the bundle size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knsv knsv knsv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove lodash from mermaid in order to reduce bundle size
2 participants
@hikerpig @knsv