Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1290 Hide/style today marker in gantt diagram #1336

Merged
merged 2 commits into from
Apr 11, 2020
Merged

#1290 Hide/style today marker in gantt diagram #1336

merged 2 commits into from
Apr 11, 2020

Conversation

GDFaber
Copy link
Member

@GDFaber GDFaber commented Apr 5, 2020

📑 Summary

Added hiding and styling the today marker (red line) in gantt diagrams.

Resolves #1290

📏 Design Decisions

Added todayMarker keyword to parser and modified drawing the today line according to definition. Added unit tests and integration tests.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@GDFaber
Copy link
Member Author

GDFaber commented Apr 5, 2020

I'll create a new issue for completing the docs for gantt diagrams, some sections are not filled yet. The todayMarker settings can be added there as well.

@knsv knsv merged commit 7cd8b6f into mermaid-js:develop Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Red line in Gantt
2 participants