Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchor and script support in link click events #1222

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Fix anchor and script support in link click events #1222

merged 2 commits into from
Jan 27, 2020

Conversation

GDFaber
Copy link
Member

@GDFaber GDFaber commented Jan 26, 2020

📑 Summary

Reenabled support for anchor links and javascript execution if security level is set to 'loose'.

Resolves #1218

📏 Design Decisions

Removed protocol auto-completion from utils.js/formatUrl(). Added unit tests and integration tests.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@knsv knsv merged commit b6f0b25 into mermaid-js:develop Jan 27, 2020
@GDFaber GDFaber deleted the bug/1218_fix_link_click_events branch January 27, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"#id" Syntax Not Working for Flowchart Click Events
3 participants