Gantt: Add support for callback with parameters #1136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to address: #921
After researching this issue I agreed with Dunning-Kruger that it seemed prudent to support passing in the node identifier as the callback parameter as a solution. I then found that the project already supports this for flowcharts. Gantt charts, on the other hand, already support passing in custom parameters to a callback function. This, however, was not reflected in the documentation.
For continuity between flowchart and Gantt, I added in code to automatically pass in the task identifier to the callback function if no custom callback parameters are specified. I also added interaction documentation based off of the documentation for flowchart and #804.
This would be my first contribution so any feedback would be appreciated.