Bug/1061 Cannot mark members as protected in class diagram

[jgreywolf]

Using # to indicate protected status of a member or method causing parser error when not used inside class declaration brackets {}. Removed '#' from LABEL regex

Resolves #1061

[klemmchr]

Great, thanks for your contribution. According to our contribution docs, prs go into development. Could you rebase onto it and then change the target branch to it? Thanks!

Your newly added unit test doesn't pass, you might want to look into that.

[jgreywolf]

Your newly added unit test doesn't pass, you might want to look into that.

How can I run unit tests locally? Not finding anything in documentation...

[jgreywolf]

I fixed the syntax error in the failing test (duh), and now those are all fine. But I see that the GitHub builds failed.. I dont understand why, based on the messages provided though.

[klemmchr]

I fixed the syntax error in the failing test (duh), and now those are all fine. But I see that the GitHub builds failed.. I dont understand why, based on the messages provided though.

This is not related to your code. We just introduced GitHub builds as a testing phase, for now travis matters.

[knsv]

This looks neat! Good with improvements to the class diagrams. There is only one thing I would like to add is a render test as well. A render test really helps making sure things does not break without anyone noticing it.

It should not take more than a few minutes. Look at cypress\integration\rendering\classDiagram.spec.js. Just copy a test and replace the diagram code with code showing your changes .

After this I will merge this. 🎉

[jgreywolf]

@knsv Are you saying that you would rather there be a separate test? As opposed to just adding to an existing test which is what I had done :)

Which does make sense

[knsv]

Good work with this one!