Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dagre-d3 master branch (for d3v5) #1018

Merged
merged 6 commits into from
Oct 23, 2019

Conversation

pravi
Copy link
Contributor

@pravi pravi commented Oct 21, 2019

Also switch back to dagre and graphlib. Fixes #990

@coveralls
Copy link

coveralls commented Oct 21, 2019

Pull Request Test Coverage Report for Build 1168

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.937%

Totals Coverage Status
Change from base Build 1167: 0.0%
Covered Lines: 3073
Relevant Lines: 5716

💛 - Coveralls

@knsv
Copy link
Collaborator

knsv commented Oct 21, 2019

Thanks for this PR! Good news with dagre family being maintained again. Will pull this BUT ... would you mind doing this from the develop branch? We are trying to keep the master ready for urgent changes.

@pravi pravi force-pushed the switch-to-dagre-d3 branch from 6aaf083 to ca5e60b Compare October 21, 2019 17:16
@pravi pravi changed the base branch from master to develop October 21, 2019 17:18
@pravi
Copy link
Contributor Author

pravi commented Oct 21, 2019

@knsv done!

@IOrlandoni IOrlandoni changed the base branch from develop to master October 21, 2019 17:47
@IOrlandoni IOrlandoni changed the base branch from master to develop October 21, 2019 17:47
@IOrlandoni
Copy link
Member

I have put develop branch in line with master. I believe your branch is now behind in commits (compared to develop), and that's why they show up in the PR... but it should still be good to go!

image

Sorry for the inconvenience!

@pravi
Copy link
Contributor Author

pravi commented Oct 22, 2019

@knsv I rebased my branch against develop. Is there anything else I need to do?

@knsv
Copy link
Collaborator

knsv commented Oct 23, 2019

@pravi All is good, will look at this now. Thanks!

@knsv knsv merged commit 364b81a into mermaid-js:develop Oct 23, 2019
@pravi
Copy link
Contributor Author

pravi commented Oct 24, 2019

@knsv thanks! Are you planning to release this soon? We'll need a new version to update gitlab.

Update: Found this https://github.com/knsv/mermaid/projects/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants