-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dagre-d3 master branch (for d3v5) #1018
Conversation
Pull Request Test Coverage Report for Build 1168
💛 - Coveralls |
Thanks for this PR! Good news with dagre family being maintained again. Will pull this BUT ... would you mind doing this from the develop branch? We are trying to keep the master ready for urgent changes. |
6aaf083
to
ca5e60b
Compare
@knsv done! |
@knsv I rebased my branch against develop. Is there anything else I need to do? |
@pravi All is good, will look at this now. Thanks! |
@knsv thanks! Are you planning to release this soon? We'll need a new version to update gitlab. Update: Found this https://github.com/knsv/mermaid/projects/6 |
Also switch back to dagre and graphlib. Fixes #990