Insecure Randomness - Issue

[karthikdav]

When scanned with Fortify scanner, it reported Insercure Randomness for function Math.random() since it was generating cryptographically weak random numbers.

[NicolaiSoeborg]

It's used in src/diagrams/git/gitGraphAst.js to generate a random id.
That function does not have to be securely random, so this isn't a problem.

If anything, then I think the random seed should be fixed to some constant to avoid hard-to-debug problems.

[knsv]

Thanks, that should be easy enoght to fix. Waiting for some comments on this proposal before ding anything though.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you are still interested in it, and it is still relevant, you can comment or remove the label to revive it.

[IOrlandoni]

If it's cheap to fix, we might as well do it so it does not show up on scans.

[mearns]

I'll take a look and send in a PR. Sounds as simple as replacing the call to Math.random() with a cryptographically secure PRNG, am I missing anything else?