Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for fontawesome glyphs that don't start with fa #713

Closed
gotoariel opened this issue Aug 16, 2018 · 1 comment
Closed

Support for fontawesome glyphs that don't start with fa #713

gotoariel opened this issue Aug 16, 2018 · 1 comment
Labels
Type: New Shape Request for new shape

Comments

@gotoariel
Copy link

gotoariel commented Aug 16, 2018 •
edited
Loading

For example the brands and some others have classes that start with different prefixes. But it is currently hardcoded: https://github.com/knsv/mermaid/blob/a4992963b3873ec7a566ba91b92596d2a360e3b9/src/diagrams/flowchart/flowRenderer.js#L71

If the pull request involves simply changing this line and the regex, I'm happy to do it, but I'm not sure where else it comes up.
@gotoariel gotoariel changed the title Support for fontawesome glyphs that don't start with fa fa-xxx Support for fontawesome glyphs that don't start with fa Aug 16, 2018
@stale
Copy link

stale bot commented Jun 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Type: New Shape Request for new shape label Jun 29, 2019
mgenereu pushed a commit to mgenereu/mermaid that referenced this issue Jun 25, 2022
@sidharthv96
Fix View does not work via building from Dockerfile mermaid-js#713
5ba2337
mgenereu pushed a commit to mgenereu/mermaid that referenced this issue Jun 25, 2022
@sidharthv96
Merge pull request mermaid-js#722 from mermaid-js/fix/713
3932e3f 
Fix View does not work via building from Dockerfile mermaid-js#713
mgenereu pushed a commit to mgenereu/mermaid that referenced this issue Jun 25, 2022
@sidharthv96
Merge remote-tracking branch 'origin/master' into develop
8e41cf1 
* origin/master:
  Fix View does not work via building from Dockerfile mermaid-js#713
  chore(deps): bump minimist from 1.2.5 to 1.2.6 (mermaid-js#721)
  Update stale.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: New Shape Request for new shape
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gotoariel