Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hexagon shape in mermaid flowchart? #530

Closed
pi314 opened this issue May 4, 2017 · 10 comments
Closed

Hexagon shape in mermaid flowchart? #530

pi314 opened this issue May 4, 2017 · 10 comments

Comments

@pi314
Copy link

pi314 commented May 4, 2017

According to the document, there are 6 shapes available (one found from the issues):
[box]
(rounded box)
((circle))
>flag-like box]
{rhombus or diamond}
(-oval-)

Is that possible to draw a hexagon in flowchart?

Normally, a flowchart uses diamond shape to represent a condition, but when the description text grows, the diamond becomes very very large. So I always use hexagons instead.

@dotancohen
Copy link

+1
This is a very valid request and I hope to see it implemented. As is, Mermaid currently makes poor use of space in general but the huge rhombi make the conditional statements very difficult to use.

I've also used hexagons in the past and they are understood by anybody familiar with conventional flowchart shape syntax.

@fzzylogic
Copy link

fzzylogic commented Nov 22, 2018

Drakon flattened the rhombus and got to space with that.

@airbj31
Copy link

airbj31 commented Feb 22, 2019

It would be wonderful if we can use various shapes.
e.g. https://www.conceptdraw.com/How-To-Guide/flowchart-design

@stale
Copy link

stale bot commented Jun 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Type: New Shape Request for new shape label Jun 29, 2019
@fzzylogic
Copy link

@Stale, flattened hexagons rule.

@stale stale bot removed the Type: New Shape Request for new shape label Jun 30, 2019
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you are still interested in it, and it is still relevant, you can comment or remove the label to revive it.

@github-actions github-actions bot added the Type: New Shape Request for new shape label Sep 24, 2019
@dotancohen
Copy link

@Stale, flattened hexagons rule.

@IOrlandoni IOrlandoni added Graph: Flow Status: Pending Is not to be executed as it currently is Type: Enhancement New feature or request and removed Type: New Shape Request for new shape labels Sep 25, 2019
@knsv knsv added Good first issue! Contributor needed Status: Approved Is ready to be worked on and removed Status: Pending Is not to be executed as it currently is labels Sep 30, 2019
@knsv
Copy link
Collaborator

knsv commented Sep 30, 2019

This should be fairly easy to implement. How so you think the syntax should be for the hexagon?

When implementing this, don't forget:

  • Add examples in the documentation under docs
  • Add an e2e tests for this

@mearns
Copy link
Contributor

mearns commented Oct 3, 2019

Making some pretty quick progress on this, should have a completed PR in a few days.

mearns added a commit to mearns/mermaid that referenced this issue Oct 3, 2019
The hexagon shape in flow chart now fits
the width and height independently, so it can better fit
large content without taking up too much space.
mearns added a commit to mearns/mermaid that referenced this issue Oct 3, 2019
mearns added a commit to mearns/mermaid that referenced this issue Oct 3, 2019
The "corner" triangles are a fixed ratio to the height,
so the triangles will always be mathemtically similar.
mearns added a commit to mearns/mermaid that referenced this issue Oct 3, 2019
mearns added a commit to mearns/mermaid that referenced this issue Oct 3, 2019
mearns added a commit to mearns/mermaid that referenced this issue Oct 3, 2019
mearns added a commit to mearns/mermaid that referenced this issue Oct 3, 2019
mearns added a commit to mearns/mermaid that referenced this issue Oct 5, 2019
mearns added a commit to mearns/mermaid that referenced this issue Oct 5, 2019
mearns added a commit to mearns/mermaid that referenced this issue Oct 5, 2019
mearns added a commit to mearns/mermaid that referenced this issue Oct 5, 2019
mearns added a commit to mearns/mermaid that referenced this issue Oct 5, 2019
@IOrlandoni
Copy link
Member

Resolved on #970

@mermaid-js mermaid-js locked as resolved and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants