-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to use # or ; in gantt diagram #1981
Comments
Hi! I've just bumped into the same problem. Luckiliy, the solution is described here my bad, this works in sequenceDiagram, but not in Gantt, sorry. |
any update on this ? |
technically this should be an easy fix , but getting close to a year . |
any update ? |
Alongside with I think we need to have a quotation and escaping syntax for them. Like:
|
In my testing, against the current Live Editor (v10.3.0), these are the ones that currently don't work:
Would love to know if anyone finds any other chars that need special handling while we wait for a fix 😄 Thanks. |
This seems to be a duplicate/connected with issue #1817. Should these two be connected or should a greater issue be generated to encompass all characters that cannot be used in Gantt labels? |
I would like to try tackling this issue. |
Is there any reason why on line 89 the parser excludes semicolons and hash symbols? I'm trying to better understand the Jison parser responsible for parsing through the Gantt syntax. |
I took the time to clearly document different behaviors caused by different symbols when created a Gantt Diagram. I will be working with the Gantt example provided by the Mermaid Live editor (here). I also made sure to pull the latest changes from the developer branch and ran the developer environment on in FireFox while testing for different situations.
Which of these points are bugs and which ones are acceptable consequences of the parser? |
As of Mermaid 10.8, these characters are no longer unsafe. See: * mermaid-js/mermaid#1981 * mermaid-js/mermaid#5095 * https://github.com/mermaid-js/mermaid/releases/tag/v10.8.0
this doesn't work
escaping is also not possible not quoting the text
Just put a # or ; in the THISHASH and you can see the parsing error
https://mermaid-js.github.io/mermaid-live-editor/#/edit/eyJjb2RlIjoiZ2FudHRcbiAgICB0aXRsZSBIQVNIVEVTVFxuVEhJU0hBU0ggIDoyMDIxLTA0LTAzIDExOjA2OjA3LCAyc2VjIiwibWVybWFpZCI6e30sInVwZGF0ZUVkaXRvciI6ZmFsc2V9
thanks
The text was updated successfully, but these errors were encountered: