Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add layout-elk #1518

Merged
merged 1 commit into from
Aug 28, 2024
Merged

feat: Add layout-elk #1518

merged 1 commit into from
Aug 28, 2024

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Aug 28, 2024 •
edited by aloisklink
Loading

📑 Summary

Brief description about the content of your PR:

Resolves #1516

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable:

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@netlify Netlify
Copy link

netlify bot commented Aug 28, 2024 •
edited
Loading

✅ Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit d023a11
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/66cf14857774fa000880b576
😎 Deploy Preview https://deploy-preview-1518--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Aug 28, 2024

Mermaid Live Editor    Run #1548

Run Properties:  status check passed Passed #1548  •  git commit f39e1708a5 ℹ️: Merge d023a1142b99ac01f15278abc18625680bab4a71 into 3fbe4a80c8dc2d3a95c96a111ba1...
Project Mermaid Live Editor
Branch Review sidv/elkLoader
Run status status check passed Passed #1548
Run duration 02m 57s
Commit git commit f39e1708a5 ℹ️: Merge d023a1142b99ac01f15278abc18625680bab4a71 into 3fbe4a80c8dc2d3a95c96a111ba1...
Committer Sidharth Vinod
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 6
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

ashishjain0512
ashishjain0512 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Verified on Preview link: https://deploy-preview-1518--mermaidjs.netlify.app/edit#pako:eNpV0MFqhDAQBuBXGQKSFvQFPBS62t3LQku7N7OHQUcTVhOJCcuiefdGLaXNKcn_zcDMzGrTEMtZksxKK5fDzJ2kgXgOXJN3FnsOKW97c68lWsdX0VCLvnefpBuyZFdL_Y1DCCFJhP7FcCmFhnheq0JaNbkBpytk2ctyIgeD0fRY4PB0MjBJM45Kd8-7P6wIivm8MgInlb6FPSq2-ndNC5TVGUdnxuvf5HI3C7xV6kPG9v8TaSlWHasW8xazGi0UaDfCUjaQHVA1cRXz-iPYtgbB8nj9mVcwoUOk6J35euia5c56Spk1vpMs9uyn-PJjg45KhZ3FYSfhG8d_dQk

@ashishjain0512 ashishjain0512 added this pull request to the merge queue Aug 28, 2024
Merged via the queue into develop with commit eaf8eb4 Aug 28, 2024
11 checks passed
@ashishjain0512 ashishjain0512 deleted the sidv/elkLoader branch August 28, 2024 12:24
@aloisklink aloisklink mentioned this pull request Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashishjain0512 ashishjain0512 ashishjain0512 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elk renderer is broken
2 participants
@sidharthv96 @ashishjain0512