Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Link to contribution guidelines #1405

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Fix Link to contribution guidelines #1405

merged 1 commit into from
Feb 19, 2024

Conversation

BaumiCoder
Copy link
Contributor

The linked markdown file in the github repository only contains the path to the actual file with the guidelines. Furthermore, there is a rendered version on the website, which shows the diagramms and not the code of them.

📑 Summary

Fix the link to the contribution guidelines for the pull request template, so that the page at the online documentation is the target.

📏 Design Decisions

A rendered web page is nicer than a path or the markdown which is at this path .

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

The linked markdown file in the github repository only contains
the path to the actual file with the guidelines. Furthermore,
there is a rendered version on the website, which shows the diagramms
and not the code of them.
Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit c005cf4
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/65cfae45dc37c50008855589
😎 Deploy Preview https://deploy-preview-1405--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sidharthv96 sidharthv96 merged commit a501827 into mermaid-js:develop Feb 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants