ci: fix skipping **Upload to Percy** on errors #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, when a test fails, the **Upload to Percy** CI job still runs, and fails. I think this is because our syntax for the `if:` statement was wrong and had an extra newline/spaces, that was making GitHub Actions treat the statement as always `true`. According to https://github.com/orgs/community/discussions/25641#discussioncomment-10617902, apparently `>-` and removing the outer `${{` and `}}` might help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Right now, when a test fails, the Upload to Percy CI job still runs, and fails.
I think this is because our syntax for the
if:statement was wrong and had an extra newline/spaces, that was making GitHub Actions treat the statement as alwaystrue.According to https://github.com/orgs/community/discussions/25641#discussioncomment-10617902, apparently
>-and removing the outer${{and}}might help.📏 Design Decisions
N/A
📋 Tasks
Make sure you
masterbranch