Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use node:18.20-alpine3.19 in Docker build #734

Conversation

aloisklink
Copy link
Member

📑 Summary

Chromium 128.0.6613.84-r0 (used in Alpine 3.20) seems to be having issues with puppeteer/mermaid-cli, so we can't use it yet.

Resolves failing CI in recent PRs (see https://github.com/mermaid-js/mermaid-cli/actions/workflows/compile-mermaid.yml), e.g.:

$ bash run-tests.sh test-positive mermaid-js/mermaid-cli/mermaid-cli:10.9.2-PullRequest0733.12
Generating single mermaid chart

ProtocolError: Page.enable timed out. Increase the 'protocolTimeout' setting in launch/connect calls for a higher timeout if needed.
    at new Callback (file:///home/mermaidcli/node_modules/puppeteer-core/lib/esm/puppeteer/common/Connection.js:58:35)
    at CallbackRegistry.create (file:///home/mermaidcli/node_modules/puppeteer-core/lib/esm/puppeteer/common/Connection.js:103:26)
    at Connection._rawSend (file:///home/mermaidcli/node_modules/puppeteer-core/lib/esm/puppeteer/common/Connection.js:212:26)
    at CDPSessionImpl.send (file:///home/mermaidcli/node_modules/puppeteer-core/lib/esm/puppeteer/common/Connection.js:419:78)
    at FrameManager.initialize (file:///home/mermaidcli/node_modules/puppeteer-core/lib/esm/puppeteer/common/FrameManager.js:133:24)
    at CDPPage._CDPPage_initialize (file:///home/mermaidcli/node_modules/puppeteer-core/lib/esm/puppeteer/common/Page.js:834:70)
    at CDPPage._create (file:///home/mermaidcli/node_modules/puppeteer-core/lib/esm/puppeteer/common/Page.js:57:90)
    at file:///home/mermaidcli/node_modules/puppeteer-core/lib/esm/puppeteer/common/Target.js:125:32
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async Target.page (file:///home/mermaidcli/node_modules/puppeteer-core/lib/esm/puppeteer/common/Target.js:128:23)

📏 Design Decisions

I've picked Node.JS v18.20, since it's a recent version of Node.JS v18.

We can use @dependabot to automatically update this later.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted master branch

Chromium 128.0.6613.84-r0 (used in Alpine 3.20) seems to be having
issues with puppeteer/mermaid-cli, so we can't use it yet.
@aloisklink aloisklink merged commit 294af9f into mermaid-js:master Aug 26, 2024
8 checks passed
@aloisklink aloisklink deleted the build/use-node-18.20-alpine3.19-for-docker-build branch August 26, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant