fix: add warning for mixed casing in FROM and AS keywords #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a warning for the `FromAsCasing` rule, addressing the issue of inconsistent casing between the `FROM` and `AS` keywords in Dockerfiles. The rule enforces consistent casing for readability and maintainability, providing a warning message when mixed casing occurs. ### Changes: - Added a warning message: `WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line X)` ### Examples: ❌ **Bad:** `FROM` is uppercase, `AS` is lowercase. `FROM debian:latest as builder` ✅ Good: FROM and AS are both uppercase. `FROM debian:latest AS deb-builder` ✅ Good: FROM and AS are both lowercase. `from debian:latest as deb-builder` For more information, refer to the Dockerfile checks documentation: [Dockerfile FROM-AS Casing](https://docs.docker.com/reference/build-checks/from-as-casing/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a warning for the
FromAsCasingrule, addressing the issue of inconsistent casing between theFROMandASkeywords in Dockerfiles. The rule enforces consistent casing for readability and maintainability, providing a warning message when mixed casing occurs.Changes:
WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line X)Examples:
❌ Bad:
FROMis uppercase,ASis lowercase.FROM debian:latest as builder✅ Good: FROM and AS are both uppercase.
FROM debian:latest AS deb-builder✅ Good: FROM and AS are both lowercase.
from debian:latest as deb-builderFor more information, refer to the Dockerfile checks documentation: [Dockerfile FROM-AS Casing](https://docs.docker.com/reference/build-checks/from-as-casing/