Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Pom signing plugin definition #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

david-merge
Copy link
Contributor

@david-merge david-merge commented Nov 30, 2021

Description of the change

Some pom fixes

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

https://app.asana.com/0/1201041540145493/1201327726921934

Checklists

Development

  • The code changed/added as part of this pull request has been covered with tests, or the description above explains how testing was performed

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or gif attached. Download "Kap" from the Mac App store for easy gif screen capture.

@@ -21,6 +21,17 @@
<distribution>repo</distribution>
</license>
</licenses>
<distributionManagement>
<snapshotRepository>
<id>ossrh</id>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only ever used Jfrog not Sonatype but it seems like they're both major players in maven repo hosting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants