port rpcgen to mercury for hg_proc_cb_t function generation #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chuckcranor could you please rebase your PR on top of latest master? the CI got unfortunately broken when github runners were moved to latest ubuntu and I just fixed them. Thanks! |
chuckcranor
force-pushed
the
hg_rpcgen
branch
2 times, most recently
from
0e3c410 to
2987eb8
Compare
Port sunrpc rpcgen to mercury to allow mercury users to generate
hg_proc_cb_t functions from .x files (as an additional alternative
to hand coding or using the boost preprocessor macros). The
mercury version of rpcgen (hg_rpcgen) parses standard .x files
(though it ignores the 'program' section) and emits code that
uses the mercury proc API.
The port includes:
- rpcgen itself, in util/rpc_gen (hg_info is moved to util/hg_info)
- mercury proc versions of helper xdr functions like xdr_array()
in src/proc_extra. we update the legacy string functions in
src/proc_extra to use hg_proc_string() for a backend.
- a new unit test in Testing/unit/hg/test_hg_rpcgen.c
The unit test's input .x file (Testing/unit/hg/test_hg_rpcgen.x)
also documents the the .x file syntax.
Note that the hg_rpcgen reinitialize() code has been updated to
free() previously allocated parse tree memory rather than discard
(leak) it. To do this, the char* strings in parse.h were changed
to tokens (since the token type/kind value can be used to determine
if the token string was allocated with malloc() or not).
chuckcranor
force-pushed
the
hg_rpcgen
branch
from
2987eb8 to
f042d81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port sunrpc rpcgen to mercury to allow mercury users to generate hg_proc_cb_t functions from .x files (as an additional alternative to hand coding or using the boost preprocessor macros). The mercury version of rpcgen (hg_rpcgen) parses standard .x files (though it ignores the 'program' section) and emits code that uses the mercury proc API.
The port includes:
The unit test's input .x file (Testing/unit/hg/test_hg_rpcgen.x) also documents the the .x file syntax.