Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow scalar subscriptions in gateway #508

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

simoneb
Copy link
Collaborator

@simoneb simoneb commented Jun 8, 2021

Allows using plain scalars in subscriptions in federation gateway instead of having to wrap them in types

Closes #370

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@jonnydgreen jonnydgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gateway subscriptions is trying to get subscription from his own resolvers
3 participants