-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(opentelemetry): add tracing documentation with zipkin and opentelemetry #341
doc(opentelemetry): add tracing documentation with zipkin and opentelemetry #341
Conversation
Maybe it's better for |
TODO: switch to @autotelic/fastify-opentelemetry |
@adamovittorio PTAL |
@projectjudge FYI, we can try it with the gcp/prometheus exporter and see if we can remove the custom code for the headers propagation in fastify. Then in the ctx we have access to the tracer that we can use to instantiate custom spans. |
@adamovittorio for sure, we can give it a go and update the decorator for our custom spans as well if needed |
Ok ... the gateway doesn't work as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I think we should document that this would not work with graphql-jit. Or does it? |
I didn't test this with jit enabled, I suppose it will not work for the graphql trace, but we will still get the http trace at least. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Waiting for
@opentelemetry/instrumentation-graphql
release.