Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slow tests #150

Merged
merged 1 commit into from
May 5, 2020
Merged

Fix slow tests #150

merged 1 commit into from
May 5, 2020

Conversation

frikille
Copy link
Collaborator

@frikille frikille commented May 4, 2020

This PR fixes the slow running tests:

  • test/gateway/methods.js 20s -> ~250ms
  • test/gateway/request.js 5s -> ~200ms
  • test/gateway/schema.js 5s -> ~50ms

Closes #146

mcollina
mcollina approved these changes May 5, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, interesting fix

@mcollina mcollina merged commit fe9f979 into mercurius-js:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split test/gateway/methods.js into multiple files
2 participants
@frikille @mcollina