Chore/replace tokeninfo with mint public key #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ts-client/src/vault/index.ts
Outdated
| @@ -76,7 +75,7 @@ const getAllVaultState = async (tokenInfos: Array<TokenInfo>, program: VaultProg | |||
| }); | |||
| }; | |||
|
|
|||
| const getAllVaultStateByPda = async (tokensInfoPda: Array<TokenInfoPda>, program: VaultProgram) => { | |||
| const getAllVaultStateByPda = async (tokensInfoPda: Array<PdaInfo>, program: VaultProgram) => { | |||
There was a problem hiding this comment.
should change tokensInfoPda -> vaultsInfoPda
ts-client/src/vault/index.ts
Outdated
| @@ -502,7 +500,7 @@ export default class VaultImpl implements VaultImplementation { | |||
| } | |||
|
|
|||
| // If it's SOL vault, wrap desired amount of SOL | |||
| if (this.tokenInfo.address === NATIVE_MINT.toString()) { | |||
| if (this.vaultMint.equals(NATIVE_MINT)) { | |||
There was a problem hiding this comment.
why call vaultMint? why not call it tokenMint?
I'm bit confused for that naming
ts-client/src/vault/index.ts
Outdated
| @@ -30,10 +29,10 @@ import { IDL, Vault as VaultIdl } from './idl'; | |||
| import { IDL as AffiliateIDL, AffiliateVault as AffiliateVaultIdl } from './affiliate-idl'; | |||
| import { calculateWithdrawableAmount } from './helper'; | |||
|
|
|||
| type TokenInfoPda = { info: TokenInfo; vaultPda: PublicKey; tokenVaultPda: PublicKey; lpMintPda: PublicKey }; | |||
| type PdaInfo = { vaultMint: PublicKey; vaultPda: PublicKey; tokenVaultPda: PublicKey; lpMintPda: PublicKey }; | |||
There was a problem hiding this comment.
should we reaming vaultMint to tokenMint?
andrewsource147
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.