-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify json_name to camel case for Python entities #667
base: master
Are you sure you want to change the base?
Conversation
you missed sdk/python/quote_items.py, sdk/python/product_comments.py you probably missed some other files as well |
🚀 Wrote Changes
Hi @s3341458, I decided to make the following changes:
|
python/product_comments.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is not needed please delete it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
GitHub actions yielded the following error. The command that failed is
This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests. |
GitHub actions yielded the following error. The command that failed is
This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests. I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR. |
2 similar comments
GitHub actions yielded the following error. The command that failed is
This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests. I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR. |
GitHub actions yielded the following error. The command that failed is
This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests. I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR. |
GitHub actions yielded the following error. The command that failed is
Please note that the error message is wrapped in backticks (```) for better visibility. This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests. I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR. |
4 similar comments
GitHub actions yielded the following error. The command that failed is
Please note that the error message is wrapped in backticks (```) for better visibility. This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests. I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR. |
GitHub actions yielded the following error. The command that failed is
Please note that the error message is wrapped in backticks (```) for better visibility. This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests. I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR. |
GitHub actions yielded the following error. The command that failed is
Please note that the error message is wrapped in backticks (```) for better visibility. This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests. I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR. |
GitHub actions yielded the following error. The command that failed is
Please note that the error message is wrapped in backticks (```) for better visibility. This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests. I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR. |
delete product_comments.py
GitHub actions yielded the following error. The command that failed is
Please note that the error message is wrapped in backticks (```) for better visibility. This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests. I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR. |
python/quote_items.py
Outdated
@@ -7,7 +7,7 @@ | |||
class QuoteItem(sdk.python.entities.Entity): | |||
|
|||
resource = '/quote_items' | |||
json_name = 'quote_item' | |||
json_name = 'quoteItems' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be quoteItem instead of quoteItems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Description
This PR standardizes the
json_name
attribute to use camel case for all entity classes in the Python SDK. Previously, some entities used snake case while others used camel case, leading to inconsistency. The changes ensure that alljson_name
attributes are in camel case format.Summary of Changes
json_name
attribute of theEmailAddress
class inemail_addresses.py
to 'emailAddress'.json_name
attribute of thePayment
class inpayments.py
to 'payment'.json_name
attribute of theAddress
class inaddresses.py
to 'address'.These changes have been made to ensure consistency in the naming convention across all entity classes in the Python SDK.
Fixes #666.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: