-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overview of project jobs #3749
Overview of project jobs #3749
Conversation
lorriborri
commented
Dec 16, 2024
- closes [WebUI] Use Case: Overview of project Jobs #3451
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 🚀 - I had only one thing: IMO the store is currently only written but not read anywhere. But maybe this was a necessary setup for coming features.
|
||
onMounted(async () => { | ||
try { | ||
projects.value = await defaultClient.withProjectApi.getAssignedProjectDataList() | ||
store.storeProjects(projects) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently you only store the projects - but it seems you do not check if already loaded and use the store as a cache.
Maybe this will done later - at the moment I did not find anything that uses getProjectById
(at least directly) to obtain data from store.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You observed this correctly - the store is intended for the next issue, where it will be used to show the project details. At the moment, the functionality to check if a project is already loaded and use the store as a cache is not implemented - we could address this Issue in upcoming tasks.