Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview of project jobs #3749

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Conversation

lorriborri
Copy link
Member

@lorriborri lorriborri marked this pull request as ready for review December 17, 2024 11:08
@lorriborri lorriborri requested a review from de-jcup December 17, 2024 11:08
Copy link
Member

@de-jcup de-jcup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🚀 - I had only one thing: IMO the store is currently only written but not read anywhere. But maybe this was a necessary setup for coming features.


onMounted(async () => {
try {
projects.value = await defaultClient.withProjectApi.getAssignedProjectDataList()
store.storeProjects(projects)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently you only store the projects - but it seems you do not check if already loaded and use the store as a cache.

Maybe this will done later - at the moment I did not find anything that uses getProjectById (at least directly) to obtain data from store.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You observed this correctly - the store is intended for the next issue, where it will be used to show the project details. At the moment, the functionality to check if a project is already loaded and use the store as a cache is not implemented - we could address this Issue in upcoming tasks.

@lorriborri lorriborri merged commit cbe6c59 into develop Dec 18, 2024
2 checks passed
@lorriborri lorriborri deleted the feature-3451-overview-of-project-jobs branch December 18, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WebUI] Use Case: Overview of project Jobs
2 participants