Provide templates and assets #3545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
3 times, most recently
from
5cce323 to
ad4ca93
Compare
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
from
ad4ca93 to
27232ad
Compare
de-jcup
changed the title
- usecases for asset CRUD operations - AssertFile entity + DB parts - assert service - TestUtil enhanced, now a dedicated sub folder can be defined for temporary files - implemented asset storages (+ AbstractSharedVolumeStorage) - introduced asset storage factories
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
2 times, most recently
from
6e1dacb to
7332704
Compare
- formatted code - wrote unit tests - wrote integration test - wrote DB tests - wrote RESTdoc tests - implemented logic inside asset service - wrote DAUI actions - added missing license headers
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
2 times, most recently
from
f9c63f7 to
eca68d8
Compare
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
3 times, most recently
from
4b7af4c to
5c13f87
Compare
- it is now ensured on every pds job call, that the assets in storage are same as in db. Same logic for admin create/update operation is used. - improved PDSWebScanJobScenario12IntTest which does now uses templates and assets. The test ensures that the PDS instance will receive the pds template meta data. - changed templateDefinition format. Assets now no longer an array but only one entry. Means we have 1:n relation here from asset to templates and no longer m:n. - added unit tests - introduced TemplateData resolver in commons-model which can be used from PDS and wrapper applications - introduced TemplateData inside SecHub convfiguration file - Template and Asset REST controller are now annotated with profile admin access
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
from
5c13f87 to
e346ecf
Compare
- introduced TestAPI.executeResilient which is a short term for executeRunnableAndAcceptAssertionsMaximumTimes(4, runnable, 500); - all time relevant parts inside integration test TemplateScenario1IntTest do now use this for testing
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
from
404adcb to
3f6e709
Compare
- introduced new usecase for PDS job execution (makes it easier for developers to find the relevant parts)
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
3 times, most recently
from
426b7c9 to
d4e4399
Compare
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
from
d4e4399 to
68ec5d7
Compare
winzj
requested changes
Dec 3, 2024
.../src/main/java/com/mercedesbenz/sechub/domain/administration/AdministrationAPIConstants.java
Show resolved
Hide resolved
...ain/java/com/mercedesbenz/sechub/domain/administration/project/ProjectDetailInformation.java
Outdated
Show resolved
Hide resolved
.../main/java/com/mercedesbenz/sechub/domain/administration/project/ProjectTemplateService.java
Outdated
Show resolved
Hide resolved
...s-core/src/main/java/com/mercedesbenz/sechub/commons/core/ConfigurationFailureException.java
Outdated
Show resolved
Hide resolved
sechub-doc/src/docs/asciidoc/documents/shared/snippet/pds-param-template-metadata-syntax.json
Outdated
Show resolved
Hide resolved
...ain/java/com/mercedesbenz/sechub/storage/sharevolume/spring/AbstractSharedVolumeStorage.java
Outdated
Show resolved
Hide resolved
...ain/java/com/mercedesbenz/sechub/storage/sharevolume/spring/AbstractSharedVolumeStorage.java
Outdated
Show resolved
Hide resolved
...b-scan/src/test/java/com/mercedesbenz/sechub/domain/scan/asset/AssetFileInformationTest.java
Outdated
Show resolved
Hide resolved
...b-scan/src/test/java/com/mercedesbenz/sechub/domain/scan/asset/AssetFileInformationTest.java
Outdated
Show resolved
Hide resolved
...b-scan/src/test/java/com/mercedesbenz/sechub/domain/scan/asset/AssetFileInformationTest.java
Outdated
Show resolved
Hide resolved
- added comments - moved from encryption package to own template package (shared kernel) - renamed class SecHubProjectTemplates to SecHubProjectTemplateData - created common logic for assignment and unassignment - wrote tests for ProjectTemplateService
- removed auto wire annotation where not necessary - made some fields final - fixed typos - removed unnecessary log output
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
2 times, most recently
from
a1d5845 to
2260f40
Compare
- randomness test fixed - added tests for not found variants for nextCanceledOrEndedJobsWithEncryptionPoolIdLowerThan - improved tests
de-jcup
force-pushed
the
feature-3521-templates-and-assets
branch
from
2260f40 to
5795a83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR