Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make github actions integration test platform independent #3148 #3153

Merged

Conversation

hamidonos
Copy link
Collaborator

@hamidonos hamidonos requested a review from sven-dmlr May 29, 2024 08:12
…on-tests-platform-independent

# Conflicts:
#	github-actions/scan/src/launcher.ts
Copy link
Member

@sven-dmlr sven-dmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
Please check my comments on sanitizing path strings in file 01-start.sh.

github-actions/scan/__test__/integrationtest/01-start.sh Outdated Show resolved Hide resolved
github-actions/scan/__test__/integrationtest/01-start.sh Outdated Show resolved Hide resolved
github-actions/scan/__test__/integrationtest/01-start.sh Outdated Show resolved Hide resolved
github-actions/scan/__test__/integrationtest/01-start.sh Outdated Show resolved Hide resolved
github-actions/scan/__test__/integrationtest/01-start.sh Outdated Show resolved Hide resolved
github-actions/scan/__test__/integrationtest/01-start.sh Outdated Show resolved Hide resolved
github-actions/scan/__test__/integrationtest/01-start.sh Outdated Show resolved Hide resolved
github-actions/scan/__test__/integrationtest/01-start.sh Outdated Show resolved Hide resolved
github-actions/scan/__test__/integrationtest/01-start.sh Outdated Show resolved Hide resolved
github-actions/scan/__test__/integrationtest/01-start.sh Outdated Show resolved Hide resolved
@hamidonos hamidonos merged commit 9e6d937 into develop May 29, 2024
2 checks passed
@hamidonos hamidonos deleted the gha_feature-3148-gha-integration-tests-platform-independent branch May 29, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make integration tests (GitHub Actions) platform independent
2 participants