Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable auto cleanup for old scan reports #2075 #2592

Merged

Conversation

- enabled the implementation
- changed unit test
- changed integration test
- by ignoring already existing false positives, the
  report is not loaded - means that an old false positive
  entry which points to an no longer existing report
  will make no problems. The old FP information (with meta data)
  will be still available even when the report does not exist
  and no error will be shown.
@de-jcup de-jcup force-pushed the feature-2075-auto-cleanup-shall-drop-old-scan-results branch from 5d64897 to bf79fff Compare October 12, 2023 07:46
@de-jcup de-jcup marked this pull request as ready for review October 12, 2023 07:46
@de-jcup de-jcup requested a review from sven-dmlr October 12, 2023 07:47
Copy link
Member

@sven-dmlr sven-dmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Looking forward to get the old data deleted :-)

@de-jcup de-jcup merged commit 3d740bb into develop Oct 12, 2023
1 check passed
@de-jcup de-jcup deleted the feature-2075-auto-cleanup-shall-drop-old-scan-results branch October 12, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants