Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed behavior of java api client to avoid 401 problems #2553 #2560

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

de-jcup
Copy link
Member

@de-jcup de-jcup commented Sep 21, 2023

@de-jcup de-jcup changed the title Changed behavior of java api client to avoid 404 problems #2553 Changed behavior of java api client to avoid 401 problems #2553 Sep 21, 2023
- created unit test to reproduce problem (wire mock test)
- changed login behavior, instead of using a authenticator object
  we use now a request interceptor and set the basic auth header
  directly
- removed server url and trust all setters
- introduced new constructor inside abstract SecHub client to have
  fields inside mocked client as well
@de-jcup de-jcup force-pushed the feature-2553-handle-java-client-auth-problems branch from 027180d to 142f9cc Compare September 21, 2023 15:10
@de-jcup de-jcup requested a review from Jeeppler September 21, 2023 15:12
Copy link
Member

@Jeeppler Jeeppler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. But, please fix the failing tests.

@de-jcup de-jcup requested a review from Jeeppler September 27, 2023 05:59
Copy link
Member

@Jeeppler Jeeppler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🥇 . Let's merge it.

@de-jcup de-jcup merged commit 9d89549 into develop Sep 27, 2023
1 check passed
@de-jcup de-jcup deleted the feature-2553-handle-java-client-auth-problems branch September 27, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java SecHub client - Authentication 401 problems
2 participants