Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start Integrating java api client in WebUI , SecHub client enhancements, initial WebUI containerization, Change UC-40 #2518

Merged
merged 20 commits into from
Feb 29, 2024
Merged

Start Integrating java api client in WebUI , SecHub client enhancements, initial WebUI containerization, Change UC-40 #2518

merged 20 commits into from
Feb 29, 2024

Conversation

Jeeppler
Copy link
Member

@Jeeppler Jeeppler commented Aug 28, 2023 •
edited by de-jcup
Loading

Jeeppler added 13 commits August 28, 2023 16:56
@Jeeppler
Replace status page API calls with SecHub Java API calls #2513 and im…
712eca5 
…plement #469

- return JSON instead of text for the server version #469
- adjust the REST Doc tests für #469
- replace the status page API calls with SecHub Java API calls #2513
- improve return value of server status API call #2513

closes: #2513
closes: #469
@Jeeppler
Merge branch 'develop' into feature-2513-webui-use-sechub-java-api-cl…
36413f1 
…ient
@Jeeppler
Use SecHub Mocked client #2513
0814795
@Jeeppler
Move configuration services to configuration package #2513
21210b9
@Jeeppler
Merge branch 'develop' into feature-2513-webui-use-sechub-java-api-cl…
d03b881 
…ient
@Jeeppler
Containerized WebUI #2571 and fixes for #2513
a053b60 
- start containerzing WebUI #2571
- improve the Spring profiles #2513
- fix some test #2513
- add SecHub WebUI and SecHub WebUI solution to Eclipse projects #2513
- improve WebUI controllers #2513
@Jeeppler
Containerize WebUI Solution #2571
112a096 
- containerize the WebUI solution
- small fixes
@Jeeppler
Add the README.adoc for the copy folder #2571
eadb25b
@Jeeppler
Add the README.adoc for the copy folder #2571
af722d6
@Jeeppler
Small improvements in Gradle and apply Spotless #2513
f04f301 
- apply Spotless
- ugrade Spotless
- put CycloneDX Gradle plugin into libraries.gradle
- add WebUI build in sdc.sh
@Jeeppler
Merge branch 'feature-2513-webui-use-sechub-java-api-client' of https…
607cf13 
…://github.com/mercedes-benz/sechub into feature-2513-webui-use-sechub-java-api-client
@Jeeppler
Return only server version #469
06142bb
@Jeeppler
Fix status scheduler call #2513
e931edb
@Jeeppler Jeeppler requested a review from de-jcup October 5, 2023 07:59
@Jeeppler Jeeppler marked this pull request as ready for review October 5, 2023 07:59
de-jcup
de-jcup requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@de-jcup de-jcup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but I found some points. Please read my comments.

sechub-api-java/src/main/java/com/mercedesbenz/sechub/api/DefaultSecHubClient.java Outdated Show resolved Hide resolved
sechub-api-java/src/main/java/com/mercedesbenz/sechub/api/DefaultSecHubClient.java Outdated Show resolved Hide resolved
sechub-api-java/src/main/java/com/mercedesbenz/sechub/api/DefaultSecHubClient.java Show resolved Hide resolved
sechub-api-java/src/main/java/com/mercedesbenz/sechub/api/DefaultSecHubClient.java Outdated Show resolved Hide resolved
sechub-api-java/src/main/java/com/mercedesbenz/sechub/api/MockedSecHubClient.java Outdated Show resolved Hide resolved
sechub-webui/src/main/java/com/mercedesbenz/sechub/webui/IndexController.java Outdated Show resolved Hide resolved
sechub-webui/src/main/java/com/mercedesbenz/sechub/webui/NewApiTokenController.java Outdated Show resolved Hide resolved
sechub-webui/src/main/java/com/mercedesbenz/sechub/webui/NewApiTokenService.java Outdated Show resolved Hide resolved
sechub-webui/src/main/java/com/mercedesbenz/sechub/webui/ScanController.java Outdated Show resolved Hide resolved
settings.gradle Show resolved Hide resolved
@de-jcup
Merge branch 'develop' into
1561e58 
feature-2513-webui-use-sechub-java-api-client
@de-jcup
Changed DefaultSecHubClient creation to builder pattern #2513
4b60835
@de-jcup
Rename sechub client username parts to userId #2942
d74cc5f 
- also renamed demo parts
@de-jcup
Refactorings #2513
39a8d5a
@de-jcup
Usecase changed: UC-40 renamed + changed java implementation #469
57a22f6 
-  Introduce ServerRuntimeData as Json object which will initially hold
serverVersion inside, but can be extended for future needs.
- Changed url from /api/admin/info/version to /api/admin/info/server
- Renamed usecase @UseCaseAdminChecksServerVersion to
  @UseCaseAdminFetchesServerRuntimeData
- Updated the URL builders (TestAPI)
- generated and commited new reduced open api file
- changed default sechub client implemenatation
@de-jcup
Some changes for initial WebUI docker image #2571
ac3a28a
@de-jcup de-jcup changed the title Replace manually written API calls with SecHub Java API calls #2513 Start Integrating java api client in WebUI , SecHub client enhancements, initial WebUI containerization, Change UC-40 Feb 28, 2024
@sven-dmlr
adapted to new api call /api/admin/info/server #469
91bc352 
- keep server_version behavior (string only)
- new action 'server_info' added
@de-jcup de-jcup merged commit 2fc2941 into develop Feb 29, 2024
2 checks passed
@de-jcup de-jcup deleted the feature-2513-webui-use-sechub-java-api-client branch February 29, 2024 13:36
@sven-dmlr sven-dmlr modified the milestone: Server 1.7.0 Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de-jcup de-jcup de-jcup approved these changes

Assignees

@de-jcup de-jcup

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Jeeppler @de-jcup @sven-dmlr